Identity back-endorsement becomes per-identity-type - #8401
Open
Max (maxtropets) wants to merge 1 commit into
Open
Max (maxtropets) wants to merge 1 commit into
Max (maxtropets) wants to merge 1 commit into
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The persisted schema and disaster-recovery verification path are security-sensitive and the new PQ-filtering behavior remains untested.
Pull request overview
Updates back-endorsement storage to support per-identity-type entries, advancing #7848 while preserving CLASSICAL behavior.
Changes:
- Replaces the singleton endorsement table with an identity-keyed map.
- Updates CLASSICAL readers, writers, recovery scanning, and tests.
- Defers PQ endorsement verification.
Custom instructions used: .github/copilot-instructions.md, .github/instructions/reviewing.instructions.md
File summaries
| File | Description |
|---|---|
| src/service/tables/previous_service_identity.h | Defines the identity-keyed endorsement table. |
| src/node/test/snapshotter.cpp | Updates snapshot fixtures for CLASSICAL keys. |
| src/node/rpc/network_identity_accessors_impl.h | Reads CLASSICAL endorsements from the map. |
| src/node/recovery_snapshot_ledger.h | Filters recovery scanning to CLASSICAL entries. |
| src/node/internal_tables_access.h | Updates CLASSICAL endorsement access and writes. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Amaury Chamayou (achamayou)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More of #7848.
CLASSICALas before, PQ isn't considered until further changes toprevious_service_identityconfig are made - we still expect a single cert with EC key.