Skip to content

[Quality Management] UI actions to restore default shipped source configurations#9605

Merged
JakovljevicDusan merged 5 commits into
mainfrom
bugs/QM-ResoreDefaultShippedSourceConfigurations
Jul 23, 2026
Merged

[Quality Management] UI actions to restore default shipped source configurations#9605
JakovljevicDusan merged 5 commits into
mainfrom
bugs/QM-ResoreDefaultShippedSourceConfigurations

Conversation

@JakovljevicDusan

@JakovljevicDusan JakovljevicDusan commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What & why

Adds options to unstuck environment from incomplete or damaged source configurations:

  1. Make card page editable
  2. Action in the card page 'Reset default configuration': Resets this default source configuration shipped with Quality Management, discarding any customizations made to it.
  3. Actions in the list page:
  • 'Recreate missing default configurations': Recreates any missing default source configurations shipped with Quality Management. Existing default configurations remain unchanged, even if they were customized.
  • 'Reset only default configurations': Deletes and recreates the default source configurations shipped with Quality Management, discarding any customizations made to them. Custom source configurations that have been added are preserved.
  • 'Reset all configurations': Deletes every source configuration, including custom ones that have been added, and then recreates the defaults shipped with Quality Management.

Linked work

Fixes AB#642625

@JakovljevicDusan
JakovljevicDusan requested a review from a team July 20, 2026 13:47
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 20, 2026
@JakovljevicDusan JakovljevicDusan changed the title [Quality Management] Options in the UI to restore default shipped source configurations [Quality Management] UI actions to restore default shipped source configurations Jul 20, 2026
@github-actions github-actions Bot added the SCM GitHub request for SCM area label Jul 20, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 20, 2026
Comment thread src/Apps/W1/Quality Management/test/src/QltyTestsMoreTests.Codeunit.al Outdated
@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ UI}$

The card page's AboutText still states 'It is read-only in most scenarios and intended for advanced configuration.' but this same PR removes the page's Editable = false property, making every field on the page directly editable (and adds a Reset default configuration action). The teaching-tip text now contradicts the page's actual behavior and will mislead users into thinking edits are unusual/discouraged when the page is designed to be edited directly. Update AboutText to reflect that the page is editable and that a Reset action exists to discard customizations to shipped defaults.

Agent judgement — not directly backed by a BCQuality knowledge article.

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.12.4

…QM-ResoreDefaultShippedSourceConfigurations
@github-actions

Copy link
Copy Markdown
Contributor

$\textbf{🟡\ Medium\ Severity\ —\ UI\ &\ Accessibility}$

The PR removes the page-level Editable = false guard from Qlty. Inspect. Source Config. without adding any field-level Editable = false restrictions. Steelman: this may be intended to let advanced users edit mappings inline. But the rest of the diff points the other way: the page now warns that these configurations should not be changed under normal circumstances, shipped defaults get a new reset/undo action with confirmation, and the added tests cover only the reset actions—not direct editing. As written, every record, including shipped defaults, becomes directly editable for fields such as Code, Description, Enabled, From Table No., From Table Filter, To Type, and To Table No., which is a broad write-surface change from the previously read-only UI. If inline editing is intentional, it should be explicitly justified and constrained; otherwise restore the page-level read-only guard or add deliberate field-level editability rules.

Agent judgement — not directly backed by a BCQuality knowledge article.

Line mapping was unavailable, so this was posted as an issue comment.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.13.4

@JakovljevicDusan
JakovljevicDusan added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit 384c007 Jul 23, 2026
324 of 330 checks passed
@JakovljevicDusan
JakovljevicDusan deleted the bugs/QM-ResoreDefaultShippedSourceConfigurations branch July 23, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants