[Shopify] Fix duplicate Sync Prices on B2B Catalogs and GraphQL quote escaping#7585
Open
[Shopify] Fix duplicate Sync Prices on B2B Catalogs and GraphQL quote escaping#7585
Conversation
… escaping Add confirmation dialog when enabling Sync Prices on a catalog that already has it enabled for another company, preventing conflicting pricing configs. Fix doubled single quotes in GraphQL resource files from PR #7198 migration. Fixes AB#630273 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
AL Documentation Audit
Documentation gaps were detected in the following apps:
- Shopify-Connector: 93% documentation coverage
To generate documentation, run /al-docs init or /al-docs update using GitHub Copilot CLI or Claude Code.
This review is for awareness to help keep documentation in sync with code changes. It is okay to dismiss this request.
Groenbech96
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
''→') in 3 GraphQL resource files (GetCatalogs,GetNextCatalogs,HasFulfillmentService) introduced during the PR [Shopify] Replace GraphQL query codeunits with resource files #7198 migration from AL codeunits to.graphqlresource files. In AL string literals''is an escape for', but in plain-text resource files it's literal, causing Shopify to reject the query parameters.Test plan
SyncPricesConfirmDisablesOtherLine— user confirms, other catalog line gets Sync Prices disabledSyncPricesCancelKeepsBothUnchanged— user cancels, no changesSyncPricesNoConfirmWhenNoDuplicate— no duplicate, no dialog, field enables normallyFixes AB#630273
🤖 Generated with Claude Code