fix: increase core deflate size limit to 54 KB#2738
Open
hectorhdzg wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Application Insights Core size gate unit test to allow a slightly larger deflated (compressed) bundle, preventing CI failures when the core package’s minified output grows marginally.
Changes:
- Increase the maximum allowed deflate size for both raw and bundled Core builds from 53 KB to 54 KB.
JacksonWeber
approved these changes
Jun 10, 2026
The npm install steps fail when puppeteer's postinstall (node install.mjs)
tries to download chrome-headless-shell v148 and the cache is partial
('browser folder exists but the executable is missing').
Fix:
- Add job-level PUPPETEER_SKIP_DOWNLOAD=true to gate the flaky postinstall
download during the npm install steps.
- Add an explicit 'Install Puppeteer browsers' step that names each browser
(chrome and chrome-headless-shell) so they install even with SKIP_DOWNLOAD
set (the no-arg form is a silent no-op under that env var, leaving Chrome
missing for 'npm run test').
Mirrors the non-pureview parts of microsoft#2739. The floating '>= 0.14.0 < 2.x' range let CI resolve a newer ts-utils (0.15.x) than was locked, which is what surfaced as the @microsoft/applicationinsights-shims build failure and grew the core/AISKU bundle sizes. - Bump ts-utils floor to '>= 0.15.0 < 2.x' across all source package.json files (25 packages). - Regenerate common/config/rush/npm-shrinkwrap.json so CI resolves the same pinned ts-utils 0.15.0 (verified locally). - Bump size-test thresholds to match: core RAW/BUNDLE 132 => 133 (deflate already 54); AISKU RAW/BUNDLE 174 => 175, deflate 70 => 71. Verified locally: shims build OK, core build OK, all 873 core tests pass (including the deflate/raw size checks).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.