fix: remove stale instance entry on recreate and guard stop against m…#468
Open
Syedowais312 wants to merge 1 commit into
Open
fix: remove stale instance entry on recreate and guard stop against m…#468Syedowais312 wants to merge 1 commit into
Syedowais312 wants to merge 1 commit into
Conversation
…issing containers Signed-off-by: syedowais312 <syedowais312sf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a container is removed externally (e.g.
docker system prune) andmicrocks startrecreates it, the old instance entry was never removed fromconfig causing duplicate instance records to accumulate on every recreate.
Two root causes:
RemoveInstancematched byName(not unique) instead ofContainerID(unique)autoRemovepath instop.gowas passinginstance.NametoRemoveInstance,silently failing to remove the correct entry
start.gowas clearinginstance.ContainerID = ""instead of callingRemoveInstanceto actually remove the stale record from configChanges
cmd/start.go: calllocalConfig.RemoveInstance(instance.ContainerID)toremove the stale record before recreating, instead of just clearing the local variable
cmd/stop.go: passinstance.ContainerIDtoRemoveInstancein theautoRemovepathpkg/config/localconfig.go:RemoveInstancenow matches byContainerIDinstead ofNameTesting
Ran
docker rm <container>while config showsstatus: Running, thenmicrocks start --name <instance>config shows a single clean entry withthe new container ID, no duplicates.
Realted: #456