Skip to content

fix(stop): add --name flag to stop named contexts and instances #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdeshDeshmukh wants to merge 2 commits into
base: master
Choose a base branch
from
+29 −2
Open

fix(stop): add --name flag to stop named contexts and instances #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4b8904
fix(stop): add --name flag to stop named contexts and instances
AdeshDeshmukh Jun 17, 2026
3d52be8
fix(stop): use indexed loop for pointer-safe context lookup
AdeshDeshmukh Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions cmd/stop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,17 @@ import (
)

func NewStopCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
var name string

var stopCmd = &cobra.Command{
Use: "stop",
Short: "stop microcks instance",
Long: "stop microcks instance",
Example: `# Stop the instance from the current context
microcks stop

# Stop by context name or instance name
microcks stop --name myinstance`,
Run: func(cmd *cobra.Command, args []string) {

configFile := globalClientOpts.ConfigPath
Expand All @@ -27,8 +33,27 @@ func NewStopCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
return
}

ctx, err := localConfig.ResolveContext("")
errors.CheckError(err)
var ctx *config.Context
if name != "" {
ctx, err = localConfig.ResolveContext(name)
if err != nil {
var ctxRef *config.ContextRef
for i := range localConfig.Contexts {
if localConfig.Contexts[i].Instance == name {
ctxRef = &localConfig.Contexts[i]
break
}
}
if ctxRef == nil {
log.Fatalf("No context found for '%s'", name)
}
Comment on lines +47 to +49
ctx, err = localConfig.ResolveContext(ctxRef.Name)
errors.CheckError(err)
}
} else {
ctx, err = localConfig.ResolveContext("")
errors.CheckError(err)
}
instance := ctx.Instance

if instance.Name == "" {
Expand Down Expand Up @@ -73,5 +98,7 @@ func NewStopCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command {
},
}

stopCmd.Flags().StringVar(&name, "name", "", "Name of the context or instance to stop (uses current context if empty)")

return stopCmd
}