Skip to content

Clean up IDisposable boilerplate in VideoPlayerControl #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
miclat97 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Clean up IDisposable boilerplate in VideoPlayerControl #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions QuickViewFile/Controls/VideoPlayerControl.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ protected virtual void Dispose(bool disposing)
videoInWindowPlayer.Close();
}

// TODO: free unmanaged resources (unmanaged objects) and override finalizer
// TODO: set large fields to null
disposedValue = true;
}
}
Expand Down Expand Up @@ -300,13 +298,6 @@ public TimeSpan GetCurrentVideoPosition()
return TimeSpan.FromSeconds(sliProgress.Value);
}

// // TODO: override finalizer only if 'Dispose(bool disposing)' has code to free unmanaged resources
// ~videoInWindowPlayerControl()
// {
// // Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
// Dispose(disposing: false);
// }

public void Dispose()
{
// Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
Expand Down