fix(webview): guard external link launch in WebFragment with try/catch#93
Open
jim-daf wants to merge 1 commit into
Open
fix(webview): guard external link launch in WebFragment with try/catch#93jim-daf wants to merge 1 commit into
jim-daf wants to merge 1 commit into
Conversation
shouldOverrideUrlLoading sent every non-meteocool URL to startActivity(Intent.ACTION_VIEW) without protection. If the device has no app that can handle the URL (no browser/viewer for the scheme, custom intents like mailto with no mail client, etc.) it raises ActivityNotFoundException and crashes the map fragment. Wrap the launch in try/catch and fall back to a short Toast so the fragment keeps working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92.
`WebFragment.shouldOverrideUrlLoading` hands non-meteocool URLs to a plain `startActivity(Intent.ACTION_VIEW, ...)`. If the device has no Activity that can handle the URL (some custom scheme, a link a browser cannot open, `mailto:` on a device with no mail client, etc.) the call raises `ActivityNotFoundException` and brings down the map fragment.
Change
Wrap the launch in try/catch and fall back to a Toast so the fragment keeps working:
```kotlin
try {
startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(url)))
} catch (e: ActivityNotFoundException) {
Toast.makeText(requireContext(), R.string.cant_open_link, Toast.LENGTH_SHORT).show()
}
```
Adds a `cant_open_link` string for the fallback message. The happy path (a URL with a viewer installed) is unchanged.