GRO-682 - 3 - Clean up obviously unused packages/files#1234
Merged
Conversation
tmashara
approved these changes
Jul 15, 2026
tmashara
left a comment
Contributor
There was a problem hiding this comment.
looks good, thank you for cleaning things up!
| "jest": "^27.0", | ||
| "markdownlint-cli": "^0.33.0", | ||
| "mocha": "^2.3.3", | ||
| "node-libs-browser": "0.5.2", |
Contributor
There was a problem hiding this comment.
nit: it seems like we don't need this package as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last bit of GRO-682: Initial cleanup + prep
a. E.g. astro will use a
buildscript, but package.json already has abuildscript but it doesn't do anything. I also removed some other "frontend" stuff to make it clearer that astro is The Frontend.a. We'll have unit tests with astro but probably won't use jest. Also the unit tests seem safe to remove because:
There's still a lot more than can be cleaned up in this repo, but I'd like to focus on the obvious, high priority stuff for now. Docs is still very much a Rube Goldberg machine, and I'm afraid of knocking out something load-bearing.
How to verify
The critical functionality is all in
.github/workflowsandamplify.yml. As long as that all still works, we should be good to go.So it's mainly
script/docs,script/build,script/linksandbun lint-*.Here's the successful amplify deployment: https://us-east-1.console.aws.amazon.com/amplify/apps/dkkh35gceu2po/branches/gro-682-initial-cleanup-3/deployments