Skip to content

GRO-682 - 3 - Clean up obviously unused packages/files#1234

Merged
bpander merged 3 commits into
masterfrom
gro-682-initial-cleanup-3
Jul 15, 2026
Merged

GRO-682 - 3 - Clean up obviously unused packages/files#1234
bpander merged 3 commits into
masterfrom
gro-682-initial-cleanup-3

Conversation

@bpander

@bpander bpander commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Last bit of GRO-682: Initial cleanup + prep

  1. Removes nonfunctional "frontend" stuff
    a. E.g. astro will use a build script, but package.json already has a build script but it doesn't do anything. I also removed some other "frontend" stuff to make it clearer that astro is The Frontend.
  2. Removes useless jest tests
    a. We'll have unit tests with astro but probably won't use jest. Also the unit tests seem safe to remove because:
    • nothing runs them and they haven't worked in over a year
    • most of what they test isn't used in this repo at all
    • some don't test anything meaningful, they just test functions defined in the tests themselves :jackiechan_wtf:
  3. Removes some packages obviously not used anymore. We clearly aren't using grunt, mocha, or chai for example.

There's still a lot more than can be cleaned up in this repo, but I'd like to focus on the obvious, high priority stuff for now. Docs is still very much a Rube Goldberg machine, and I'm afraid of knocking out something load-bearing.


How to verify

The critical functionality is all in .github/workflows and amplify.yml. As long as that all still works, we should be good to go.

So it's mainly script/docs, script/build, script/links and bun lint-*.

Here's the successful amplify deployment: https://us-east-1.console.aws.amazon.com/amplify/apps/dkkh35gceu2po/branches/gro-682-initial-cleanup-3/deployments

@bpander bpander self-assigned this Jul 14, 2026
@bpander bpander marked this pull request as ready for review July 14, 2026 19:44
@bpander bpander requested a review from a team July 14, 2026 19:44

@tmashara tmashara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for cleaning things up!

Comment thread package.json Outdated
"jest": "^27.0",
"markdownlint-cli": "^0.33.0",
"mocha": "^2.3.3",
"node-libs-browser": "0.5.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it seems like we don't need this package as well

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit, removed in cb6cef2

@bpander bpander merged commit 43efc03 into master Jul 15, 2026
1 check passed
@bpander bpander deleted the gro-682-initial-cleanup-3 branch July 15, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants