Skip to content

GRO-682 - 1 - Remove unused files#1229

Merged
bpander merged 5 commits into
masterfrom
gro-682-initial-cleanup-1
Jul 14, 2026
Merged

GRO-682 - 1 - Remove unused files#1229
bpander merged 5 commits into
masterfrom
gro-682-initial-cleanup-1

Conversation

@bpander

@bpander bpander commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Part of GRO-682

Removes some unused files:

  • _includes/navigation-header/desktop-menu-footer-to-financial-models.html
  • A bunch of svg includes
  • _plugins/jekyll_html_filters.rb
  • script/package.json - unused duplicate of package.json in root

How to verify:
Basically as long as this builds, we should be fine. Jekyll builds fail if you try to include a file that doesn't exist.

@bpander bpander self-assigned this Jul 13, 2026
@bpander bpander marked this pull request as ready for review July 13, 2026 19:38
@bpander bpander requested a review from a team July 13, 2026 19:38

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we can remove the reference from the navigation-header as well?
https://github.com/metabase/docs.metabase.github.io/blob/master/_includes/navigation-header.html#L52

@bpander bpander Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense. Nothing uses use_symbol_only_as_logo_on_header in docs. Removed in 15ef211.

@bpander bpander requested a review from tmashara July 14, 2026 13:18

@gantoreno gantoreno left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out on my end!

@bpander bpander merged commit dc08b26 into master Jul 14, 2026
1 check passed
@bpander bpander deleted the gro-682-initial-cleanup-1 branch July 14, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants