Add board files for nRF52840 Dongle (pca10059)#2307
Closed
JosiahWI wants to merge 2 commits intomeshcore-dev:devfrom
Closed
Add board files for nRF52840 Dongle (pca10059)#2307JosiahWI wants to merge 2 commits intomeshcore-dev:devfrom
JosiahWI wants to merge 2 commits intomeshcore-dev:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a board definition and linker script for the nRF52840 Dongle. I have chosen SoftDevice 7.3.0 for the SoftDevice version, because it is the most recent supported by MeshCore. The linker script assumes that addresses upwards of 0x80000 are occupied by the DFU bootloader that comes on the nRF52840 Dongle by default. The linker script does not work with MeshCore out of the box, because it does not leave any room for an InternalFileSystem.
I intended to open this PR on my fork, not here on upstream. I will leave it open for a bit in case anyone wants to look at it, but I expect this change to be rejected here.