Skip to content

nrf52: allow companion to sleep when idle #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oltaco wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −0
Open

nrf52: allow companion to sleep when idle #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/companion_radio/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,9 @@ void loop() {
ui_task.loop();
#endif
rtc_clock.tick();

#if defined(NRF52_PLATFORM)
board.sleep(1800);
Copy link
Copy Markdown
Contributor

@weebl2000 weebl2000 Feb 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
board.sleep(1800);
if (!the_mesh.hasPendingWork()) {
board.sleep(1800);
}

Maybe?

Probably need to add hasPendingWork(), _mgr->getOutboundCount(0xFFFFFFFF) > 0 - not sure if it's actually useful.

Copy link
Copy Markdown
Contributor

@robekl robekl Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the right direction.

board.sleep() is unconditional here, so this does not actually implement “sleep when idle”. On nRF52 NRF52Board::sleep() is a blocking sd_app_evt_wait() / __WFE() wait (src/helpers/NRF52Board.cpp:254), which means every companion build now becomes interrupt-paced even while MyMesh::loop() still has active serial or radio work to drain. That is a behavior change from the existing repeater logic, which only sleeps after !the_mesh.hasPendingWork() (examples/simple_repeater/main.cpp:137). If the intent is only idle power saving, this needs an explicit idle predicate; otherwise active USB/BLE sessions and contact syncs now pay an avoidable wait on every loop iteration.

Copy link
Copy Markdown
Contributor

@weebl2000 weebl2000 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just checking outbound is an easy extra, it will wakeup regardless though.

Copy link
Copy Markdown
Contributor

@weebl2000 weebl2000 Mar 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
board.sleep(1800);
if (_mgr->getOutboundTotal() == 0)
board.sleep(1800);

This is probably sufficient, but even without it the code should still work, but it sleeps an additional millisecond? :)

Copy link
Copy Markdown

@terminalvelocity23 terminalvelocity23 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur, added a similar check to my version.

Copy link
Copy Markdown

@mweinelt mweinelt Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
board.sleep(1800);
board.sleep(0);

Sleep on NRF52 is event-based, not time-based. See NRF52Board::sleep in src/helpers/NRF52Board.cpp, where secs is completely unused.

#endif

}