Feature/update spoke backplane - #290
Conversation
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — ✅ all passingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
Azure Backplane — ✅ all passingAzure UAMI-based automation principal conventions — applies to 1 modules
Azure Backplane — Summary
GCP Backplane — not applicableGCP workload-identity-federation automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| description = "Name of the resource group that contains the hub vnet to peer into." | ||
| } | ||
|
|
||
| variable "azure_hub_vnet_name" { |
There was a problem hiding this comment.
n: at some point in the future, i dream of a azure hub&spoke network ref arch which is able to actually manage all that vnet address space / subnet management nicely / automatically and essentially not making the user think about that vnet name here anymore...
| variable "azure_location" { | ||
| type = string | ||
| default = "germanywestcentral" | ||
| description = "Default Azure region where the spoke resource group and vnet are created." |
There was a problem hiding this comment.
n: one could design it such that you have a localtion for the connectivity rg and multiple spoke vnets for different locations (as azure networking sucks and they don't have a global network abstraction as GCP does)
|
|
||
| variable "azure_scope" { | ||
| type = string | ||
| description = "RBAC SCOPE: where the spoke deploy role is granted. Full resource path — a management group ('/providers/Microsoft.Management/managementGroups/<id>') or a subscription ('/subscriptions/<guid>'). Typically the parent of all landing zones. Not to be confused with azure_subscription_id (the provider target GUID)." |
There was a problem hiding this comment.
d: maybe add some validation reflecting the description?
| @@ -5,10 +5,9 @@ | |||
|
|
|||
|
|
|||
| variables { | |||
There was a problem hiding this comment.
d: maybe remove this test? we should aim for true smoke tests... e2e subfolder etc.
grubmeshi
left a comment
grubmeshi
left a comment
There was a problem hiding this comment.
LGTM, see minor comments
2 participants
No description provided.