refactor(meshstack/noop): take runner fixtures from test_context - #288
Draft
JohannesRudolph wants to merge 2 commits into
Draft
refactor(meshstack/noop): take runner fixtures from test_context#288JohannesRudolph wants to merge 2 commits into
JohannesRudolph wants to merge 2 commits into
Conversation
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — some checks failingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
Azure Backplane — not applicableAzure UAMI-based automation principal conventions — applies to 0 modules No applicable modules. GCP Backplane — not applicableGCP workload-identity-federation automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — ✅ all passingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
The runner e2e module read its GCP project and the meshStack endpoint from `TF_VAR_*` in the environment, which the smoke-test harness had to keep wired in two files. That is how the module broke silently when one of the two lines was removed. Both values are environment facts the harness already carries in `test_context`, so read them from there. An e2e module should never take a fixture from the environment that `test_context` can hold. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Records the rule the runner change follows, and why: a `TF_VAR_` fixture has to be wired on the harness side too, so it has a second place to go missing. Secrets stay the exception, since GitHub can only mask values one by one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
JohannesRudolph
force-pushed
the
claude/meshstack-smoke-test-pr49-31ccac
branch
from
August 24, 2026 20:03
428de2f to
3653c03
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
meshstack/nooprunner e2e module read its GCP project and the meshStack endpoint fromTF_VAR_*in the environment. Both are environment facts the smoke-test harness already carries intest_context, and keeping them as env vars meant each one was wired in two harness files thatnothing checked — which is how this test broke silently once already.
Both now come from
test_context, and thee2e-testskill records the rule: ane2e/module neverreads a fixture from the environment; only secrets do, because GitHub masks values one by one.
Ordering
Merge this before the matching harness PR, which removes
TF_VAR_gcp_project_idandTF_VAR_meshstack_endpointfrom the workflow. The harness already publishestest_context.fixtures.gcp.project_id;test_context.meshstack_endpointlands with that PR, sountil it merges the
meshstack/noopcase will report the field as missing.Verification
tofu validateon the runner module. The e2e run itself needs the harness PR (formeshstack_endpoint), so it is verified there by a single-module dispatch.🤖 Generated with Claude Code