feat(azure-vm-starterkit): add missing meshstack_integration.tf (BBD + permissions)#220
feat(azure-vm-starterkit): add missing meshstack_integration.tf (BBD + permissions)#220grubmeshi wants to merge 1 commit into
Conversation
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — some checks failingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
Azure Backplane — some checks failingAzure UAMI-based automation principal conventions — applies to 1 modules
Azure Backplane — Summary
STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
6faebac to
2fa7c08
Compare
The azure-virtual-machine-starterkit shipped only the buildingblock/ implementation — it
never had a meshstack_integration.tf, so no building block definition (and no permissions
array / ephemeral run key) was ever wired up. Its buildingblock creates a meshProject, a
meshstack_tenant_v4 and a composed Azure VM child building block via provider "meshstack" {},
which needs the auto-injected ephemeral token that only a BBD permissions array grants.
Add the integration.tf modeled on the AKS/SKE starter kits (workspace-level permissions).
Reconstructed, never tested end-to-end — input assignment types (USER_INPUT vs STATIC),
the readme, and the composed azure_vm_definition_version_uuid wiring need author review.
2fa7c08 to
cb929c4
Compare
What
The azure-virtual-machine-starterkit module shipped only its
buildingblock/implementation — it never had ameshstack_integration.tf. So no building block definition was ever created for it, which means nopermissionsarray / ephemeral run key was ever wired up. It looks forgotten and never tested end-to-end.Its buildingblock creates a
meshstack_project, ameshstack_tenant_v4, and a composed Azure VM child building block viaprovider "meshstack" {}— which only works with the auto-injected ephemeralMESHSTACK_API_TOKENthat a BBDpermissionsarray grants.Change
Add
meshstack_integration.tf(the BBD), modeled on the AKS/SKE starter kits, including:permissionswithMANAGED_BUILDINGBLOCK_SAVE(the same fix just applied to SKE/AKS onmain) so bumping the composed Azure VM child block to a new definition version succeeds — plainBUILDINGBLOCK_SAVEcannot change a block's version.buildingblock/variables.tf,hub/meshstackshared vars,building_block_definitionoutput.This was reconstructed and not tested end-to-end. Please sanity-check:
vm_location,vm_size,vm_os_typeas user inputs;azure_vm_definition_version_uuid,landing_zone_identifier,full_platform_identifieras static). Adjust to intent.azure_vm_definition_version_uuidis passed as a flat STATIC input (AKS pattern); confirm that's how the Azure VM BBD should be referenced.vm_admin_passworddeclaredsensitive = {}and forwarded to the child — verify the sensitive plumbing.🤖 Generated with Claude Code