docs(datagrid-web): source reorganization proposal (feature-slices + kernel/shell) - #2368
Draft
iobuhov wants to merge 3 commits into
Draft
docs(datagrid-web): source reorganization proposal (feature-slices + kernel/shell)#2368iobuhov wants to merge 3 commits into
iobuhov wants to merge 3 commits into
Conversation
…s + kernel/shell) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… external, slices are adapters, 5-tier layering) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
packages/pluggableWidgets/datagrid-web/docs/architecture-reorganization.md— an RFC-style proposal for reorganizing the widget'ssrc/module structure. Docs-only; no code moved.Why
A structural review of
datagrid-web/src(module tree + static import-coupling analysis) surfaced:components/(by type),features/(by slice),model/+helpers/(by layer) — so a single capability is smeared across all of them.model/stores/,helpers/state/, plus feature view-models & services); no principled split.components↔features,model↔features,model↔helpers, and an indirect loop), hubbed onmodel/tokens.ts.Proposal (summary)
Keep the good
model/internal DI/MobX pattern, but redistribute it into feature-slices + a thin shared kernel:shell → features → kernel → shared(acyclic, lint-enforceable). Deletehelpers/, give each store one home in its feature, and splittokens.tsso each feature owns its DI wiring.Includes an incremental, shippable migration path (5 steps) and a reduced-scope option (kill
helpers/+ splittokens.ts) capturing ~70% of the value for ~30% of the risk.Notes
🤖 Generated with Claude Code