Skip to content

[WC-3517]: Set default max height to 250px for Image widget #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r0b1n wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

[WC-3517]: Set default max height to 250px for Image widget #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/image-web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Changed

- We changed the default maximum height to 250 pixels for new Image widgets. Existing widgets are not affected.

### Fixed

- We fixed an issue where previews in Design and Structure modes did not respect the configured minimum and maximum image height.
Expand Down
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/image-web/src/Image.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
<caption>Minimum height</caption>
<description />
</property>
<property key="maxHeightUnit" type="enumeration" defaultValue="none">
<property key="maxHeightUnit" type="enumeration" defaultValue="pixels">
<caption>Maximum Height unit</caption>
<description />
<enumerationValues>
Expand All @@ -120,7 +120,7 @@
<enumerationValue key="viewport">Viewport</enumerationValue>
</enumerationValues>
</property>
<property key="maxHeight" type="integer" required="true" defaultValue="0">
<property key="maxHeight" type="integer" required="true" defaultValue="250">
<caption>Maximum height</caption>
<description />
</property>
Expand Down
Loading