You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No code changes (changes to documentation, CI, metadata, etc.)
Description
Two changes made to .github/workflows/ClaudeReview.yml:
--max-turns 15 → --max-turns 30 — the review was hitting the turn limit before finishing. 30 gives enough headroom for reading context files + running checks + writing the review.
New "Minimize older bot comments" (thanks for the suggestion @r0b1n) step added before the Claude step — on each synchronized or reopened run, it fetches all github-actions[bot] comments on the PR and minimizes them as OUTDATED via GraphQL, so only
the latest review is prominent. The || echo "..." ensures one failed minimize doesn't abort the whole step.
▎ Note on the sticky comment: use_sticky_comment: "true" already tries to update-in-place, but it only works if Claude's previous comment is still the last one. If another comment landed between runs (e.g., a human reviewer), the action creates a new one. The minimize step handles that edge case cleanly.
CI checks were still in progress at review time — "Check SHA in GH Actions", Snyk, and labeler checks all passed ✅. E2E, lint, and the Claude review job were still running.
Findings
⚠️ Low — GraphQL node IDs from gh pr view --json comments may not be mutation-compatible
File:.github/workflows/ClaudeReview.yml lines 52–54 Note: The gh pr view --json comments endpoint returns REST-derived comment IDs (integer-formatted strings), not the global GraphQL node IDs that minimizeComment(input: {subjectId: $id}) expects. The GraphQL mutation requires a node ID of the form IC_kwDO.... Using an integer string here will cause every minimizeComment call to fail silently (caught by || echo "...") and the step will appear to succeed without actually minimizing anything.
Fix: Fetch comments via GraphQL directly to get real node IDs:
⚠️ Low — issue_comment trigger with no author_association guard in auto-review job
File:.github/workflows/ClaudeReview.yml (existing, not changed in this PR) Note: The auto-review job's if: condition filters by repo name and user login but does not guard against the issue_comment event path — however the job's if: already filters github.event_name == 'pull_request' so this is not an active issue. Just noting it is already correctly scoped. Not a new problem introduced by this PR.
Positives
The || echo "..." fallback on each minimizeComment call is good defensive practice — a single failed minimize won't abort the whole step.
The concurrency group with cancel-in-progress: true correctly scopes to the PR number, preventing stacked review runs from piling up.
All action references (actions/checkout, aws-actions/configure-aws-credentials, anthropics/claude-code-action) are SHA-pinned with version comments — exactly as required.
The auto-review job correctly guards against fork PRs via head.repo.full_name == 'mendix/web-widgets'.
The interactive job restricts @claude mentions to MEMBER, COLLABORATOR, and OWNER associations, preventing external contributors from triggering privileged workflows.
timeout-minutes: 15 is set on both jobs.
--max-turns 30 is a reasonable headroom increase given the documented turn-limit problem; it matches the new step count (context read + checks + minimize + review write).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
No code changes (changes to documentation, CI, metadata, etc.)
Description
Two changes made to .github/workflows/ClaudeReview.yml:
the latest review is prominent. The || echo "..." ensures one failed minimize doesn't abort the whole step.
▎ Note on the sticky comment: use_sticky_comment: "true" already tries to update-in-place, but it only works if Claude's previous comment is still the last one. If another comment landed between runs (e.g., a human reviewer), the action creates a new one. The minimize step handles that edge case cleanly.