You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem: All 14 tests call toHaveScreenshot("bubbleChart*.png") but the corresponding e2e/BubbleChart.spec.js-snapshots/ directory with PNG baselines does not exist in this PR. Playwright fails immediately when no baseline is present — it cannot diff against a missing file, so every snapshot test will error on CI with "Missing expected screenshot". Compare: packages/pluggableWidgets/line-chart-web/e2e/LineChart.spec.js-snapshots/ contains committed PNGs for every test.
Fix: Generate and commit the baseline screenshots:
# From the bubble-chart-web package directory
pnpm run e2e -- --update-snapshots
# Then commit the generated e2e/BubbleChart.spec.js-snapshots/*.png files
git add packages/pluggableWidgets/bubble-chart-web/e2e/BubbleChart.spec.js-snapshots/
git commit -m "test(bubble-chart-web): add e2e screenshot baselines"
⚠️ Low — Redundant waitForMendixApp call in beforeEach
File:packages/pluggableWidgets/bubble-chart-web/e2e/BubbleChart.spec.js line 6
Note: The test fixture imported from @mendix/run-e2e/fixtures already patches page.goto to call waitForMendixApp internally before resolving. Calling it again explicitly after await page.goto("/") means the Mendix-ready check runs twice per test. Not harmful, but redundant. The pattern in line-chart-web omits the explicit call:
test.beforeEach(async({ page })=>{awaitpage.goto("/");// waitForMendixApp is called automatically by the patched page.goto in fixtures});
Positives
All element locators use .mx-name-* selectors — the most stable option available in Mendix E2E tests.
Test groups (bubble color, bubble size, data series, legend, axis label, grid lines) map cleanly to widget configuration axes, making it easy to trace failures to a feature area.
{ retry: 3 } on every screenshot test is a practical guard against chart-rendering flakiness in CI.
playwright.config.cjs correctly delegates to @mendix/run-e2e/playwright.config.cjs — no config drift risk.
Session management is correctly handled: the extended test fixture from @mendix/run-e2e/fixtures performs window.mx.session.logout() at worker teardown, satisfying the session-limit requirement without needing an explicit afterEach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Test related change (New E2E test, test automation, etc.)
Description
Add bubble chart e2e using mxcli CC command e2e workflow(#2240)