Open
Conversation
iobuhov
reviewed
Apr 15, 2026
Collaborator
There was a problem hiding this comment.
This file needs bit of refactoring.
- We need extract all logic (useEffect) to function, so we can test it.
- We should create new type for tree, something like TreeState that should replace multiple useRefs
- Line 26 -> let's use type literlas
Also, how we prevent recursion?
iobuhov
reviewed
Apr 15, 2026
Collaborator
There was a problem hiding this comment.
Same here, we need extract logic to function so we can write unit tests
iobuhov
reviewed
Apr 15, 2026
| (node: TreeNodeV2DataItem) => { | ||
| if (node.treeNodeState === TreeNodeState.EXPANDED) { | ||
| node.treeNodeState = TreeNodeState.COLLAPSED_WITH_CSS; | ||
| forceRender(version => version + 1); |
Collaborator
There was a problem hiding this comment.
forceRender uses useReducer with default n => n + 1 reducer. This removes need to always pass function to forceRender
iobuhov
requested changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Description