Skip to content

[MOO-2224]: Intro Screen TalkBack/VoiceOver fix #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MxKevinBeqo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MOO-2224]: Intro Screen TalkBack/VoiceOver fix #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/intro-screen-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- We fixed an issue with the TalkBack/VoiceOver traversal in the IntroScreen widget, where the order was not correct.

## [4.3.0] - 2026-4-9

### Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/intro-screen-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "intro-screen-native",
"widgetName": "IntroScreen",
"version": "4.3.0",
"version": "4.3.1",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
21 changes: 17 additions & 4 deletions packages/pluggableWidgets/intro-screen-native/src/SwipeableContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,19 @@
};

const renderItem = useCallback(
({ item }: any): ReactElement => {
return <View style={[{ width }, { height }]}>{item.content}</View>;
({ item, index }: any): ReactElement => {
const isActive = index === activeIndex;
return (
<View
style={[{ width, flex: 1 }]}
importantForAccessibility={isActive ? "auto" : "no-hide-descendants"}
accessibilityElementsHidden={!isActive}
>
{item.content}
</View>
);
},
[width, height]
[width, height, activeIndex]

Check warning on line 139 in packages/pluggableWidgets/intro-screen-native/src/SwipeableContainer.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

React Hook useCallback has an unnecessary dependency: 'height'. Either exclude it or remove the dependency array
);

const renderButton = (
Expand Down Expand Up @@ -284,6 +293,9 @@
: props.styles.dotStyle
]}
onPress={() => onPaginationPress(i)}
accessibilityRole="button"
accessibilityLabel={`Go to slide ${i + 1}`}
accessibilityState={{ selected: rtlSafeIndex(i) === activeIndex }}
/>
))}
{!hidePagination && paginationOverflow && (
Expand Down Expand Up @@ -356,9 +368,10 @@
renderItem={renderItem}
onMomentumScrollEnd={onMomentumScrollEnd}
scrollEventThrottle={50}
extraData={width}
extraData={[width, activeIndex]}
onLayout={onLayout}
keyExtractor={(_: any, index: number) => "screen_key_" + index}
importantForAccessibility="no"
/>
{renderPagination()}
</View>
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/intro-screen-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="IntroScreen" version="4.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="IntroScreen" version="4.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="IntroScreen.xml" />
</widgetFiles>
Expand Down
Loading