[MOO-1836]: fix feedback widget logo issues and make WCAG compliant#490
Open
[MOO-1836]: fix feedback widget logo issues and make WCAG compliant#490
Conversation
| titleSending?: DynamicValue<string>; | ||
| titleResult?: DynamicValue<string>; | ||
| labelFeedbackInput?: DynamicValue<string>; | ||
| placeholderFeedback?: DynamicValue<string>; |
Contributor
There was a problem hiding this comment.
As we discussed , these props are added to the component to support the language translation . I think we are making component heavy by introducing these props for only the language purpose . Can we avoid these ?
Contributor
There was a problem hiding this comment.
To add to this, I am a bit suspicious of handling localization in this manner, since no other Widget does it like this i.e. 'passing props for individual text fields'.
Maybe it is the responsibility of the User to manage different DataSources dynamically and Studio Pro should only expose the fields for override.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
Relevant changes
Feedback widget strings were hardcoded, they were updated to enable language translation.
Custom logo issue was fixed.