Skip to content

[MOO-2364] Update to hermes-compiler v1 (19.x.x) #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MxKevinBeqo wants to merge 8 commits into
base: release/19.x.x
Choose a base branch
from
Open

[MOO-2364] Update to hermes-compiler v1 (19.x.x) #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
352f836
feat: switch to hermes v1
MxKevinBeqo Jul 15, 2026
8d46ead
fix: update hermes v1 to latest ...0.16
MxKevinBeqo Jul 20, 2026
91aa831
fix: remove hard pinning of entire hermes v1 and kept only hermes com…
MxKevinBeqo Jul 20, 2026
bd1452c
fix: switch to using hermes ...0.14
MxKevinBeqo Jul 21, 2026
c664069
fix: add custom hermesc location for android
MxKevinBeqo Jul 21, 2026
a61c3cc
fix: hermesc path when building from different OS
MxKevinBeqo Jul 21, 2026
f07f223
fix: linux permission to run hermesc overriden variant
MxKevinBeqo Jul 21, 2026
2349524
fix: hermes path for ci
MxKevinBeqo Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/android-build-custom-dev-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ jobs:

- name: npm install
run: npm ci

- name: Make Hermes compiler executable (Linux)
run: chmod +x ./node_modules/react-native/node_modules/hermes-compiler/hermesc/linux64-bin/hermesc

- name: Add NDK 27.3.13750724
run: echo "y" | ${ANDROID_HOME}/cmdline-tools/latest/bin/sdkmanager --install "ndk;27.3.13750724"
Expand Down
17 changes: 17 additions & 0 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ apply plugin: "org.jetbrains.kotlin.android"
apply plugin: "com.facebook.react"
apply plugin: 'org.jetbrains.kotlin.plugin.compose'

import org.gradle.internal.os.OperatingSystem

/**
* This is the configuration block to customize your React Native Android app.
* By default you don't need to apply any configuration, just uncomment the lines you need.
Expand Down Expand Up @@ -47,6 +49,20 @@ apply plugin: 'org.jetbrains.kotlin.plugin.compose'
//
// The list of flags to pass to the Hermes compiler. By default is "-O", "-output-source-map"
// hermesFlags = ["-O", "-output-source-map"]

def hermescDir = file("${rootDir}/../node_modules/react-native/node_modules/hermes-compiler/hermesc")

@vadymv-mendix vadymv-mendix Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why do we need this override - hermes compilation is done by Studio Pro, not NT

@MxKevinBeqo MxKevinBeqo Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically only for the CI pipeline because it runs the bundle generation task createBundleDevDebugJsAndAssets.
From what I saw, the variant we build in the pipeline is not in the debuggableVariants, so it does the js compilation - bundling as well.

I did a quick search on removing the bundling as a task from the command in the CI file, and in theory it could be done e.g.
run: ./gradlew assembleDevDebug -x :app:createBundleDevDebugJsAndAssets

def os = OperatingSystem.current()

if (os.isMacOsX()) {
hermesCommand = "${hermescDir}/osx-bin/hermesc"
} else if (os.isLinux()) {
hermesCommand = "${hermescDir}/linux64-bin/hermesc"
} else if (os.isWindows()) {
hermesCommand = "${hermescDir}/win64-bin/hermesc.exe"
} else {
throw new GradleException("Unsupported OS for Hermes compiler: " + OperatingSystem.current())
}

/* Autolinking */
autolinkLibrariesWithApp()
}
Expand Down Expand Up @@ -144,6 +160,7 @@ dependencies {

configurations.all {
resolutionStrategy {
force "com.facebook.hermes:hermes-android:${rootProject.ext.hermesVersion}"
force "androidx.annotation:annotation:1.1.0"
force(
"com.google.android.gms:play-services-base:18.6.0",
Expand Down
4 changes: 4 additions & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
buildscript {
ext {
hermesVersion = new groovy.json.JsonSlurper()
.parse(file("../package.json"))
.overrides["hermes-compiler"]

buildToolsVersion = "36.0.0"
minSdkVersion = 29
compileSdkVersion = 36
Expand Down
2 changes: 1 addition & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ android.nonTransitiveRClass=true
android.suppressUnsupportedCompileSdk=33
newArchEnabled=true
hermesEnabled=true
hermesV1Enabled=false
hermesV1Enabled=true
mendixnative.cookieEncryption=false
VisionCamera_enableCodeScanner=true

Expand Down
3 changes: 0 additions & 3 deletions ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ ENV['RCT_NEW_ARCH_ENABLED'] = '1'
ENV['RCT_USE_PREBUILT_RNCORE'] = '1'
ENV['RCT_USE_RN_DEP'] = '1'

# The JS bundle is compiled compiled using a different version than the prebuilt Hermes engine embedded in the native binary, causing a runtime crash.
ENV['RCT_HERMES_V1_ENABLED'] = '0'

# Use it to require both react-native's and this package's scripts:
node_require('react-native/scripts/react_native_pods.rb')
node_require('react-native-permissions/scripts/setup.rb')
Expand Down
18 changes: 9 additions & 9 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
PODS:
- FBLazyVector (0.84.1)
- hermes-engine (0.15.1):
- hermes-engine/Pre-built (= 0.15.1)
- hermes-engine/Pre-built (0.15.1)
- hermes-engine (250829098.0.9):

@vadymv-mendix vadymv-mendix Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is still using the old version

- hermes-engine/Pre-built (= 250829098.0.9)
- hermes-engine/Pre-built (250829098.0.9)
- IQKeyboardManager (6.5.19)
- libavif/core (0.11.1)
- libavif/libdav1d (0.11.1):
Expand Down Expand Up @@ -69,7 +69,7 @@ PODS:
- ReactCommon/turbomodule/core
- ReactNativeDependencies
- Yoga
- OpenSSL-Universal (3.6.0000)
- OpenSSL-Universal (3.6.2000)
- RCTDeprecation (0.84.1)
- RCTRequired (0.84.1)
- RCTSwiftUI (0.84.1)
Expand Down Expand Up @@ -2666,7 +2666,7 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/Libraries/FBLazyVector"
hermes-engine:
:podspec: "../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec"
:tag: hermes-v0.15.1
:tag: hermes-v250829098.0.9
MendixNative:
:path: "../node_modules/mendix-native"
op-sqlite:
Expand Down Expand Up @@ -2862,14 +2862,14 @@ EXTERNAL SOURCES:

SPEC CHECKSUMS:
FBLazyVector: e97c19a5a442429d1988f182a1940fb08df514da
hermes-engine: e171ce5eb126654bf3fe00c8c6ac64370354a6c7
hermes-engine: 054cdf1294d0852c33cd980e7fcd94b4274ed8b3
IQKeyboardManager: c8665b3396bd0b79402b4c573eac345a31c7d485
libavif: 84bbb62fb232c3018d6f1bab79beea87e35de7b7
libdav1d: 23581a4d8ec811ff171ed5e2e05cd27bad64c39f
libwebp: 02b23773aedb6ff1fd38cec7a77b81414c6842a8
MendixNative: b0ea153b893ce40b90016f397e9a5acfe4444c33
op-sqlite: e9ef65bcf95a97863874cee87841425bb71c8396
OpenSSL-Universal: 9110d21982bb7e8b22a962b6db56a8aa805afde7
OpenSSL-Universal: ecee7b138fa75a74ecf00d7ffd248fb584739b9e
RCTDeprecation: af44b104091a34482596cd9bd7e8d90c4e9b4bd7
RCTRequired: bb77b070f75f53398ce43c0aaaa58337cebe2bf6
RCTSwiftUI: afc0a0a635860da1040a0b894bfd529da06d7810
Expand Down Expand Up @@ -2962,7 +2962,7 @@ SPEC CHECKSUMS:
RNReanimated: e47df7f4580997c3a46b1e736ce3f26010985bb7
RNScreens: 6cb648bdad8fe9bee9259fe144df95b6d1d5b707
RNSVG: c69f7709226108f5eb89b5aa8833c17a36345468
RNWorklets: 7d24538032e023ed207e3b4d9b234695ddadd201
RNWorklets: 06ce05d69455cc14f5676c177050a39aa557d4d2
SDWebImage: e9fc87c1aab89a8ab1bbd74eba378c6f53be8abf
SDWebImageAVIFCoder: afe194a084e851f70228e4be35ef651df0fc5c57
SDWebImageSVGCoder: 15a300a97ec1c8ac958f009c02220ac0402e936c
Expand All @@ -2971,6 +2971,6 @@ SPEC CHECKSUMS:
SwiftAudioEx: f6aa653770f3a0d3851edaf8d834a30aee4a7646
Yoga: c0b3f2c7e8d3e327e450223a2414ca3fa296b9a2

PODFILE CHECKSUM: 7a33012cce520784bb5b691549f5ed2af273b7e3
PODFILE CHECKSUM: 336902a926a1c6b0b4e426a1eeb85e04f7bbf783

COCOAPODS: 1.16.2
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,14 @@
"react": "19.2.3",
"react-dom": "19.2.3",
"react-native": "0.84.1",
"hermes-compiler": "250829098.0.14",
"unset-value": "2.0.1",
"semver": "7.7.4"
},
"resolutions": {
"react": "19.2.3",
"react-dom": "19.2.3",
"react-native": "0.84.1"
"react-native": "0.84.1",
"hermes-compiler": "250829098.0.14"
}
}
Loading