Add bitrate configuration support#24
Merged
Merged
Conversation
khamilowicz
force-pushed
the
add-bitrate
branch
3 times, most recently
from
3cd992a to
e73a71c
Compare
varsill
requested changes
Jun 15, 2026
| to scene changes; expressed in milliseconds, defaults to 2 seconds. | ||
| """ | ||
|
|
||
| @type t :: %__MODULE__{bitrate: non_neg_integer(), virtual_buffer_size_ms: non_neg_integer()} |
Collaborator
There was a problem hiding this comment.
[NIT] Perhaps instead of virtual_buffer_size_ms it would be good to have virtual_buffer_size expressed in Membrane.Time.t()?
Collaborator
There was a problem hiding this comment.
It would be good to have a @tag :vulkan test as well
varsill
requested changes
Jun 16, 2026
| * bitrate - desired bitrate of the stream; expressed in bits per second. | ||
| * virtual_buffer_size - virtual buffer duration for rate control smoothing; | ||
| larger values increase bitrate stability, smaller values improve responsiveness | ||
| to scene changes; expressed in nanoseconds as `Membrane.Time.t()`, defaults to 2 seconds. |
Collaborator
There was a problem hiding this comment.
Suggested change
| to scene changes; expressed in nanoseconds as `Membrane.Time.t()`, defaults to 2 seconds. | |
| to scene changes; expressed as `Membrane.Time.t()`, defaults to 2 seconds. |
(Membrane.Time's should be opaque i.e. it's internal representation shouldn't be relevant - and it can change at any time)
| spikes while maintaining average bitrate constraints; expressed in bits per second. | ||
| * virtual_buffer_size - virtual buffer duration for rate control smoothing; larger values | ||
| increase bitrate stability, smaller values improve responsiveness to scene changes; | ||
| expressed in nanoseconds as `Membrane.Time.t()`, defaults to 2 seconds. |
Collaborator
There was a problem hiding this comment.
Suggested change
| expressed in nanoseconds as `Membrane.Time.t()`, defaults to 2 seconds. | |
| expressed as `Membrane.Time.t()`, defaults to 2 seconds. |
| max_bitrate: max, | ||
| virtual_buffer_size: vbr_ns | ||
| }) do | ||
| vbr_ms = trunc(vbr_ns / 1_000_000) |
Collaborator
There was a problem hiding this comment.
Suggested change
| vbr_ms = trunc(vbr_ns / 1_000_000) | |
| vbr_ms = Membrane.as_milliseconds(:round) |
it also applies to the rest of places where you "manually" convert from Membrane.Time.t() to milliseconds etc. :D
…ocs, add vulkan test - Replace manual time division with Membrane.Time.as_milliseconds/2 for converting Membrane.Time.t() to milliseconds in all encoder parameter functions (vkvideo, h264_ffmpeg, h265_x265) - Update documentation to say 'expressed as Membrane.Time.t()' instead of 'expressed in nanoseconds as Membrane.Time.t()' since the type is opaque - Add @tag :vulkan test for bitrate conversion to verify Vulkan-accelerated transcoding works correctly with bitrate settings Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for configuring bitrate settings in the transcoder plugin.
Supports both ffmpeg and Vulcan bitrate settings. For constant bitrate for ffmpeg, https://trac.ffmpeg.org/wiki/Encode/H.264#CBRConstantBitRate approach is used