-
-
Notifications
You must be signed in to change notification settings - Fork 664
feat: modernize platform/device detection + Application fullscreen API (#1467) #1485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
obiot
wants to merge
17
commits into
master
Choose a base branch
from
fix/1467-platform-detection-modernize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+485
−273
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7f9fecc
fix(platform): catch iPadOS 13+ + deprecate dead-platform flags (#1467)
obiot 9de375c
fix(input): drop `isMobile` gate on keyboard event registration (#1467)
obiot 611ecef
refactor(system): convert device.js to TypeScript (#1467)
obiot 9183006
fix(device): restore `let autoFocus` (was flipped to `const` by lint)
obiot ba60914
review(copilot): address inline feedback on #1485
obiot d78126c
feat(application): move requestFullscreen / exitFullscreen onto Appli…
obiot 3b3fb5a
review(application): add `isFullscreen`, clean up the device fullscre…
obiot ec4e896
review: un-deprecate device.isFullscreen — it's a pure document probe…
obiot edf14a7
review(copilot): three rounds of inline feedback on #1485
obiot b35cb5a
feat(examples): bind F → fullscreen toggle on AfterBurner
obiot e2f59a3
feat(examples): actually add the F→fullscreen handler on AfterBurner
obiot f69bf64
fix(examples): F→fullscreen + dynamic HUD positions in AfterBurner
obiot c1f9265
chore(examples): add melonJS credit + tighten bottom-strip layout
obiot 290e1fc
review(copilot): mark `isIPadOnMacUA` as `@internal`
obiot d4c2da3
fix(lint): add JSDoc `@param` / `@returns` to `isIPadOnMacUA`
obiot 34f8a6c
chore(examples): drop debug-plugin from AfterBurner
obiot e8650ad
review(copilot): vendor-prefix exitFullscreen on both call sites
obiot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.