Fix component definition rule to match McCode instrument.y - #302
Merged
g5t merged 2 commits intoAug 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
INHERITkeyword was introduced to disambiguateCOPYin components fromCOPY({identifier})in instruments.An ADR in McCode indicated that the change was for component sections and the change in component definition was overlooked here.
This PR adds
INHERITas an allowed copying keyword to the component definition statement. If the targeted McCode runtime version is older thanv3.5.31DEFINE COMPONENT carbon COPY sourceis expected while for later versionsDEFINE COMPONENT descendant INHERIT ancestoris expected -- an informative log entry is written if the opposite keyword is provided but no error is raised.