fix: configure the atelier format instead of replacing it - #162
Merged
Conversation
The project declared `format: html`, which replaced the `atelier-html` format set by the project type rather than configuring it. Every format contribution was dropped without a warning: the skip link, focus ring, external-link, ordinal-date and navbar-tooltip scripts were never injected, the language fell back to `en` from `en-GB`, and the extension stylesheet had to be listed by path to come back at all. Declare `atelier-html` instead. The format supplies its own stylesheet again, so the hardcoded path into the extension can go, and the project layer still wins the cascade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navbar tooltips never appeared, and none of the other
atelierscripts did either.docs/_quarto.ymldeclaredformat: html, which replaces theatelier-htmlformat contributed by the project type rather than configuring it. Everyformats.htmlcontribution was dropped, with no warning at render time: the skip link, focus-ring and other accessibility fixes, the external-link treatment, the ordinal dates and the navbar tooltips were never injected,langfell back toenfromen-GB, and the extension stylesheet only came back because it was listed by an explicit path into_extensions/.Declaring
atelier-htmlrestores all of it. The format supplies its own stylesheet again, so the hardcoded path can go, while the project stylesheet still comes last and wins the cascade.Verified in the rendered output: all five scripts are injected,
lang="en-GB", the dark syntax-highlighting stylesheet is linked, tippy is loaded, and the colour-scheme toggle carries thetitlethe tooltip binds to.