feat: add quarto 1.10 and generate the version lists - #161
Merged
Conversation
awk getline returns -1 for a missing or unreadable file and the read loop simply does not run, so a lost artifact would have committed an empty code block instead of failing. Check the artifact before injecting. Render the website on pull requests as well, so a broken docs change is caught before it reaches main, and split the Pages upload and deployment into their own job so pull request runs neither deploy nor record a deployment. Fall back to the workflow token when the app key is out of reach on fork pull requests. Hoist the duplicated target file to the job environment and drop the .nojekyll step, which does nothing when Pages is served from an artifact.
Adding a version-pinned configuration previously meant editing the build matrix, the configuration table and three prose ranges by hand, so the documentation drifted from .devcontainer/ as soon as one was missed. Derive the build matrix from the .devcontainer/quarto-* directories, and generate the configuration table and the version ranges at render time with a filter that reads the same directories. Adding a configuration is now the only step required. Sort versions numerically so that 1.10 follows 1.9 rather than 1.1.
The navbar token overrides repeated the palette hex values already set in _brand.yml, so the two could drift. Reference the generated brand Sass variables instead, add the muted navbar tone to the palette, and drop the unused slate entry. Extract the shared panel and lead-in rules behind placeholders, since the hero, the section cards and the Codespaces entry points were three copies of the same surface with slightly different padding. Replace both marked sections of the quarto check page in a single awk pass; the output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #160, which was merged before its review fixes landed.
Quarto 1.10. Adds
.devcontainer/quarto-1.10/, identical to the other version-pinned configurations apart from the version.Adding one previously meant editing the build matrix, the configuration table and three prose ranges by hand, so the documentation drifted from
.devcontainer/as soon as one was missed. The build matrix is now derived from the.devcontainer/quarto-*directories, anddocs/assets/filters/devcontainer-configurations.luagenerates the configuration table and the version ranges from the same directories at render time. Versions sort numerically, so1.10follows1.9rather than1.1. Adding a configuration directory is now the only step required.Review fixes.
awkgetlinereturns-1for a missing or unreadable file and the read loop simply does not run, so a lost artifact would have committed an empty code block todocs/reference/quarto-check.qmdand auto-merged it; the injection now checks the artifact first. The website is rendered on pull requests, so a broken docs change is caught before it reachesmain, with the Pages upload and deployment split into their own job so pull request runs neither deploy nor record a deployment. The duplicated target file moves to the job environment, and the.nojekyllstep is dropped since it does nothing when Pages is served from an artifact.Cleanup. The navbar token overrides repeated palette hex values already set in
_brand.yml, so the two could drift; they now reference the generated brand Sass variables. The hero, section cards and Codespaces entry points were three copies of one surface, now shared behind placeholders. Both marked sections of thequarto checkpage are replaced in a singleawkpass, verified to produce byte-identical output.