Skip to content

feat: add quarto 1.10 and generate the version lists - #161

Merged
mcanouil merged 3 commits into
mainfrom
ci/docs-review-fixes
Jul 26, 2026
Merged

feat: add quarto 1.10 and generate the version lists#161
mcanouil merged 3 commits into
mainfrom
ci/docs-review-fixes

Conversation

@mcanouil

@mcanouil mcanouil commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Follow-up to #160, which was merged before its review fixes landed.

Quarto 1.10. Adds .devcontainer/quarto-1.10/, identical to the other version-pinned configurations apart from the version.

Adding one previously meant editing the build matrix, the configuration table and three prose ranges by hand, so the documentation drifted from .devcontainer/ as soon as one was missed. The build matrix is now derived from the .devcontainer/quarto-* directories, and docs/assets/filters/devcontainer-configurations.lua generates the configuration table and the version ranges from the same directories at render time. Versions sort numerically, so 1.10 follows 1.9 rather than 1.1. Adding a configuration directory is now the only step required.

Review fixes. awk getline returns -1 for a missing or unreadable file and the read loop simply does not run, so a lost artifact would have committed an empty code block to docs/reference/quarto-check.qmd and auto-merged it; the injection now checks the artifact first. The website is rendered on pull requests, so a broken docs change is caught before it reaches main, with the Pages upload and deployment split into their own job so pull request runs neither deploy nor record a deployment. The duplicated target file moves to the job environment, and the .nojekyll step is dropped since it does nothing when Pages is served from an artifact.

Cleanup. The navbar token overrides repeated palette hex values already set in _brand.yml, so the two could drift; they now reference the generated brand Sass variables. The hero, section cards and Codespaces entry points were three copies of one surface, now shared behind placeholders. Both marked sections of the quarto check page are replaced in a single awk pass, verified to produce byte-identical output.

awk getline returns -1 for a missing or unreadable file and the read loop
simply does not run, so a lost artifact would have committed an empty code
block instead of failing. Check the artifact before injecting.

Render the website on pull requests as well, so a broken docs change is
caught before it reaches main, and split the Pages upload and deployment
into their own job so pull request runs neither deploy nor record a
deployment. Fall back to the workflow token when the app key is out of
reach on fork pull requests.

Hoist the duplicated target file to the job environment and drop the
.nojekyll step, which does nothing when Pages is served from an artifact.
@mcanouil mcanouil added the Type: CI/CD 🤖 Issues related to continuous integration and deployment label Jul 26, 2026
@mcanouil mcanouil self-assigned this Jul 26, 2026
mcanouil added 2 commits July 26, 2026 19:08
Adding a version-pinned configuration previously meant editing the build
matrix, the configuration table and three prose ranges by hand, so the
documentation drifted from .devcontainer/ as soon as one was missed.

Derive the build matrix from the .devcontainer/quarto-* directories, and
generate the configuration table and the version ranges at render time
with a filter that reads the same directories. Adding a configuration is
now the only step required.

Sort versions numerically so that 1.10 follows 1.9 rather than 1.1.
The navbar token overrides repeated the palette hex values already set in
_brand.yml, so the two could drift. Reference the generated brand Sass
variables instead, add the muted navbar tone to the palette, and drop the
unused slate entry.

Extract the shared panel and lead-in rules behind placeholders, since the
hero, the section cards and the Codespaces entry points were three copies
of the same surface with slightly different padding.

Replace both marked sections of the quarto check page in a single awk
pass; the output is unchanged.
@mcanouil mcanouil changed the title ci: guard the transcript injection and render docs on pull requests feat: add quarto 1.10 and generate the version lists Jul 26, 2026
@mcanouil mcanouil added the Type: Enhancement 💡 Issues related to enhancements, improvements, new features, or new analyses label Jul 26, 2026
@mcanouil
mcanouil merged commit fa77676 into main Jul 26, 2026
14 checks passed
@mcanouil
mcanouil deleted the ci/docs-review-fixes branch July 26, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: CI/CD 🤖 Issues related to continuous integration and deployment Type: Enhancement 💡 Issues related to enhancements, improvements, new features, or new analyses

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant