feat: Add accessibility and parking indicators to new timetable - #3410
Open
joshlarson wants to merge 2 commits into
Open
feat: Add accessibility and parking indicators to new timetable#3410joshlarson wants to merge 2 commits into
joshlarson wants to merge 2 commits into
Conversation
smartling-github-connector
Bot
added
the
Not Ready for Translation
joshlarson
removed
the
Not Ready for Translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: ⛴️ Add parking and accessibility to new timetable stop row headers
Implementation
Screenshots
Direct current-main-versus-new comparison to show how much better the world is with these icons there.
Comparison of the old timetable component (with the feature flag disabled) with the results of this PR - to show that we're getting closer and closer to feature parity.
How to test
Check out the Winthrop and Quincy timetables (those are good ferry choices because they're the only ones with docks that have parking). Framingham/Worcester is a good commuter rail timetable to look at because it has all four permutations of accessible/inaccessible and parking/no-parking (Newtonville has neither icon, for instance).