Discover renamed boards — admission by service UUID, not just name prefix#14
Merged
Conversation
The scanner admitted peripherals into discovery by local-name prefix
("MetaWear") alone, so a renamed board — "bob" — silently vanished from
the Nearby list on any host that hadn't remembered it, despite
advertising the MetaWear service UUID in every packet. With renames now
first-class (PR #13), the quirk was promoted from curiosity to bug.
Admission is now any of: the default name prefix, the MetaWear service
UUID (ScanResult now carries advertised service UUIDs — the central
manager saw them but dropped them), or MbientLab manufacturer data (the
MAC broadcast). MetaBoot-mode boards match none of the three and stay
excluded on purpose: the normal connect flow can't talk to a
bootloader.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #13's rename work: the scanner admitted peripherals into discovery by local-name prefix ("MetaWear") alone, so a renamed board ("bob") silently vanished from Nearby on any host that hadn't remembered it — despite advertising the MetaWear service UUID in every packet.
Admission is now any of three signals: the default name prefix, the MetaWear service UUID (
ScanResultnow carries advertised service UUIDs — the central manager saw them but dropped them before this), or MbientLab manufacturer data (the MAC broadcast). MetaBoot-mode boards match none and stay excluded on purpose — the normal connect flow can't talk to a bootloader.6 new admission tests (renamed-by-UUID, case-insensitivity, MAC-broadcast path, foreign-peripheral and MetaBoot rejection); 1046/1046 SPM tests, app builds.
Hardware check on merge: rename a board to something un-MetaWear-like, forget it, scan — it should appear under Nearby.
🤖 Generated with Claude Code