Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled libtap dependency is unmaintained and has caused build problems with project compiler flags. This spike replaces it with cmocka to evaluate the migration and its failure output.
The changes convert the C tests, remove the libtap submodule, and add cmocka discovery to Autotools and CMake. CMake can fetch cmocka when it is absent. CI dependency setup includes a source build for 32-bit jobs. The four Perl test scripts remain.
This is an exploratory draft. The framework choice is still open, including a small set of internal helpers, Unity, or utest.h.
Known limitations:
Validation: a fresh Linux CMake build with the installed cmocka passed all 29 CTest tests.
git diff --check HEADpassed. The current Autotools and cross-platform CI changes have not been validated locally. Passing tests do not resolve the known assertion defects above.Related: STF-1731, formerly ENG-5416.