Skip to content

Update heartbeat handling documentation#722

Closed
DGames95 wants to merge 1 commit into
mavlink:masterfrom
DGames95:patch-1
Closed

Update heartbeat handling documentation#722
DGames95 wants to merge 1 commit into
mavlink:masterfrom
DGames95:patch-1

Conversation

@DGames95

@DGames95 DGames95 commented Jun 19, 2026

Copy link
Copy Markdown

mavlink_connection.wait_heartbeat() method does not error on timeout, it returns None mirroring recv_match()

The current documentation implies that the heartbeat is received as long as the method exits without error.

This updates the handling of a None type to avoid silently accepting a timeout.

mavlink_connection.wait_heatbeat() method does not error on timeout, it returns None mirroring recv_match()
@hamishwillee

Copy link
Copy Markdown
Collaborator

Thanks, but this is incorrect. By default hb = the_connection.wait_heartbeat() will either return with a connection or wait forever, so there is no case where this returns None. YOu could make it like that by adding a timeout, but that would be different code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants