ReportHeader - update UI screenshots (feature branch) - #121
Draft
tzi wants to merge 12 commits into
Draft
Conversation
The DataTable search moved from the table footer into the shared ReportHeader (matomo-org/matomo#24986), which changes every report screenshot.
Taken from the core branch that moves the report actions behind the header's 3-dots trigger, rebuilt on the pin core's base branch now records so the images carry that base's rendering rather than the one the earlier branch was generated against.
Core moves the annotations view into the report header's menu, so the footer of the visits-over-time graph loses its speech-bubble and the period selector beside it shifts left.
Core moves the period selector into the report header's menu as a submenu, so the visits-over-time footer keeps only its row-limit selector.
Update the UI screenshots for the report header actions menu
The evolution graph's header now holds a promoted selector's height whether or not one is out, so everything under it moves down by ten pixels.
Ten reports, all the same size as before: the title and the controls beside it line up on their centres now, and the two control clusters keep 8px apart.
…carrier Take the image the annotations icon leaves behind in the footer
Take the image the period selector leaves behind in the footer
Take the image the reserved selector height leaves in the header
The report header lifts Export out of its 3-dots menu into a control of its own, so the line above every full-page report in this plugin changed with it.
Show period sits against the 3-dots now, with the export control to its left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature branch for the report header work in this plugin: it carries the 9 expected UI screenshots regenerated for the DataTable search moving from the table footer into the shared report header.
Merged into this branch
Impact
None visible to users: expected test screenshots only.
Step by step tests
Nothing to exercise by hand. The screenshots come from the CI artifacts of matomo-org/matomo#24986 and are verified by the core feature branch, matomo-org/matomo#25059.
Note on the UI tests
The plugin's own UI jobs run against core
6.x-dev, which does not yet contain the report header change, so they compare these screenshots against a core that renders the old footer search and go red. They turn green once matomo-org/matomo#25059 lands. Merge this only together with that PR.Checklist