Suggestion: Remove highlighting for properties/methods/struct field accesses#103
Open
Gustaf-C wants to merge 2 commits intomathworks:masterfrom
Open
Suggestion: Remove highlighting for properties/methods/struct field accesses#103Gustaf-C wants to merge 2 commits intomathworks:masterfrom
Gustaf-C wants to merge 2 commits intomathworks:masterfrom
Conversation
Gustaf-C
force-pushed
the
remove_misleading_highlighting
branch
from
44a779a to
03d5f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I suggested in mathworks/MATLAB-language-server#84, this removes highlighting for properties, methods and struct fields. These are impossible to distinguish reliably with regex and I feel that the error rate is high enough not to give any benefit. Example below with semantic highlighting enabled:
I admit that I think that it does look worse, but I believe that it's just a matter of habit.
If you believe that this change is reasonable, the tests will need to be updated. I'll wait with that until I get your opinion though.
A possible alternative is to create a new scope for method calls, which would at least allow for custom highlighting.