Drop unused YAML PHP extension as optional dependency#1802
Open
ngandrass wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are currently switching from the deprecated PECL over to PIE. During this process we found that the STACK question type still has an optional dependency on the yaml PHP extension.
The yaml extension was introduced in 2020 as per a57f18f as a side-effect of requiring the mbstring PHP extension (probably an import from earlier?).
The commit 3ceabf4 introduced the alternative implementation symfony/yaml and 940bb61 finally removed the last use of any yaml PHP extension function. Threfore I propose dropping the old yaml PECL extension from the list of optional dependencies.
Changes
This PR:
environment.xmlby adding a missing</PHP_EXTENSIONS>closing tag as per fd30d7d