Skip to content

Topology lemmas - #2014

Open
Brixfoly wants to merge 4 commits into
math-comp:masterfrom
Brixfoly:topology_lemmas
Open

Brixfoly wants to merge 4 commits into
math-comp:masterfrom
Brixfoly:topology_lemmas

Conversation

@Brixfoly

@Brixfoly Brixfoly commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor
Motivation for this change

fyi @affeldt-aist @hoheinzollern @mkerjean
The goal of this PR is to add the topological notion of separability (which is useful for the implementation of the Bochner Integral I was doing, but it is useful for a lot of other stuff), with some lemmas alongside it. It also contains a lemma basisP that states the equivalence between the definition of a topological basis with neighbourhoods and the one with open sets.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@Brixfoly

Brixfoly commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

A bit broken because it is on top of pr 2008 (but can be made independent from it)

@Brixfoly

Brixfoly commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Shouldn't have added anything past commit dc44e76

@affeldt-aist

Copy link
Copy Markdown
Member

@Brixfoly can you try to rebase? I forgot what it was about :-(

@affeldt-aist

Copy link
Copy Markdown
Member

@Brixfoly can you try to rebase? I forgot what it was about :-(

ping

@Brixfoly

Copy link
Copy Markdown
Contributor Author

Ok the merge is wrong I should have checked, I will do another version

@Brixfoly

Copy link
Copy Markdown
Contributor Author

@affeldt-aist It should be good to go now, I've cleaned up some proof, tell me if the lemmas look ok to you

@affeldt-aist

affeldt-aist commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

@t6s you might want to take a look at this PR (it is about basis, should be treated soon)

@t6s

t6s commented Oct 2, 2026

Copy link
Copy Markdown
Member

The contents look nice. The code would only need some minor cleaning so that it would follow the style guide (spacing and indentation). I would also suggest documenting the intention in the PR comment (currently a one-liner "fyi ...").

@Brixfoly

Brixfoly commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

I have made an update of this (rebase+name clean-up following your recommendations), but I still need to push it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants