Identifier improvement - #2145
Merged
Merged
Conversation
/item? serves as a way to operate on a single document by using the composite key rather than _id
…_one override methods Contributions have some special logic associated with their Identities that need to be ran
…have consistent naming
bfoley12
marked this pull request as ready for review
August 31, 2026 22:07
…ly in our routers This lets us modify Identity over time without having to keep functions in line manually
… of using model_fields directly
…omponent subclasses Also revised ComponentIdentity docstring
…nomenclature with other domains
… used ContributionIdentity Previously used ContributionIdentityQuery to sidestep 'condition_key', but condition_key works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand the usage of
Identityacross all domains to normalize how natural Identifiers work.Major changes:
Identitysubclasses/item?routes handle single-document operations using natural identifiers rather thanObjectIds