Skip to content

fix: make Windows QA runs reliable - #244

Merged
matdev83 merged 2 commits into
mainfrom
fix/windows-task-reliability
Aug 1, 2026
Merged

fix: make Windows QA runs reliable#244
matdev83 merged 2 commits into
mainfrom
fix/windows-task-reliability

Conversation

@matdev83

Copy link
Copy Markdown
Owner

What changed

  • add bounded cross-platform child process execution with Windows process-tree cleanup
  • route Windows Make/QA/parity/module checks through bounded PowerShell orchestration
  • make ACP lookup-cache concurrency tests deterministic and add bounded SQLite contention retries
  • reduce repeated architecture/backend-plugin test work while preserving dedicated integration gates
  • fix plugin/test temp staging ownership and add an opt-in stale temp cleanup command

Validation

  • make OS=Windows_NT quality-checks
  • focused taskrunner, runtimebundle, journalstore, QA, backend-plugin release-gate, and Kiro spec tests
  • Windows local-compatible parity/module targets
  • ACP nested-module executable-cache tests

Linux-only race and release evidence remains authoritative in CI.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 102 files, which is 2 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 21e2968a-e53a-4dd0-ad26-4dbcf0a4b580

📥 Commits

Reviewing files that changed from the base of the PR and between 1886845 and 938a410.

📒 Files selected for processing (102)
  • .kiro/specs/archive/windows-task-reliability/design.md
  • .kiro/specs/archive/windows-task-reliability/requirements.md
  • .kiro/specs/archive/windows-task-reliability/research.md
  • .kiro/specs/archive/windows-task-reliability/spec.json
  • .kiro/specs/archive/windows-task-reliability/tasks.md
  • .release-files
  • Makefile
  • cmd/lipstd/compatible_diagnostics_test.go
  • cmd/lipstd/main.go
  • cmd/lipstd/reload_signal_contract_other_test.go
  • connector-support/acp/lookpath.go
  • connector-support/acp/lookpath_test.go
  • internal/archtest/backend_plugin_architecture_test.go
  • internal/archtest/budgets.go
  • internal/archtest/contract_lipapi_auth_imports_test.go
  • internal/archtest/core_auth_boundaries_test.go
  • internal/archtest/core_transport_helpers_thin_test.go
  • internal/archtest/cursorsdk_boundaries_test.go
  • internal/archtest/dual_plane_economics_dag_test.go
  • internal/archtest/enterprise_module_test.go
  • internal/archtest/hexagonal_migration_baseline_test.go
  • internal/archtest/host_caller_graph_test.go
  • internal/archtest/identity_transport_boundaries_test.go
  • internal/archtest/runtime_transport_boundaries_test.go
  • internal/archtest/runtimehost_ownership_test.go
  • internal/archtest/scope_boundary_test.go
  • internal/archtest/shrinkage_test.go
  • internal/core/concurrencyauthority/compatible/attempt_provider_test.go
  • internal/core/concurrencyauthority/compatible/rules.go
  • internal/infra/backendplugins/trust/open_windows_test.go
  • internal/infra/endpoint/endpoint_fuzz_test.go
  • internal/infra/endpoint/endpoint_test.go
  • internal/infra/metering/journalstore/append_race_test.go
  • internal/infra/metering/journalstore/durable.go
  • internal/infra/metering/journalstore/phase34_remediation_red_test.go
  • internal/infra/metering/journalstore/sqlite_retry.go
  • internal/infra/metering/journalstore/sqlite_retry_contract_test.go
  • internal/infra/runtimebundle/compatible_diagnostics_test.go
  • internal/infra/runtimebundle/composition_root.go
  • internal/infra/runtimebundle/continuity_open.go
  • internal/infra/runtimebundle/discovered_factories.go
  • internal/infra/runtimebundle/doctor_ownership_test.go
  • internal/infra/runtimebundle/host_build.go
  • internal/infra/runtimebundle/plugin_catalog.go
  • internal/infra/runtimebundle/plugin_inspect.go
  • internal/infra/runtimebundle/plugin_serve_leak_test.go
  • internal/infra/runtimebundle/plugin_serve_leak_windows_test.go
  • internal/infra/runtimebundle/process_services.go
  • internal/infra/runtimebundle/process_services_types.go
  • internal/infra/runtimebundle/staging_cache_main_test.go
  • internal/infra/runtimebundle/staging_cache_test.go
  • internal/infra/runtimebundle/validate_distribution.go
  • internal/infra/runtimebundle/validate_structural.go
  • internal/infra/runtimebundle/validate_structural_test.go
  • internal/plugins/backends/alibabatokenplanintl/plugin_test.go
  • internal/qa/windows_task_reliability_contract_test.go
  • internal/standardplugins/backends_alibaba_token_plan_intl_test.go
  • internal/standardplugins/compatible_diagnostics_live.go
  • internal/standardplugins/compatible_inventory_provenance_test.go
  • internal/standardplugins/compatible_tokenizer_test.go
  • internal/standardplugins/custom_backend_env_keys_test.go
  • internal/standardplugins/identity_transport_test.go
  • internal/stdhttp/reasoning_preservation_http_harness_test.go
  • internal/testkit/postgres_env.go
  • internal/testkit/postgres_env_test.go
  • scripts/backend-plugin-module-checks.ps1
  • scripts/quality-checks.ps1
  • scripts/race-check.ps1
  • scripts/taskrunner.ps1
  • scripts/tmp-clean.ps1
  • scripts/windows-task.ps1
  • testdata/enterprise_module/main.go
  • testdata/enterprise_module/main_internal_test.go
  • testdata/enterprise_module/main_test.go
  • tools/backendplugin/bounded_orchestration_contract_test.go
  • tools/backendplugin/crossplatform_qa/main.go
  • tools/backendplugin/installed_plugin_smoke/main.go
  • tools/backendplugin/isolated_root_qa/main.go
  • tools/backendplugin/main_test.go
  • tools/backendplugin/package_plugins/main.go
  • tools/backendplugin/release_gates/catalog.go
  • tools/backendplugin/release_gates/conformance.go
  • tools/backendplugin/release_gates/conformance_test.go
  • tools/backendplugin/release_gates/main.go
  • tools/backendplugin/release_gates/tidy_check.go
  • tools/backendplugin/runner/runner.go
  • tools/backendplugin/runner/runner_test.go
  • tools/backendplugin/tools_test.go
  • tools/kiro/speccheck/cursor_sdk_backend_test.go
  • tools/taskrunner/cmd/lip-taskrunner/main.go
  • tools/taskrunner/cmd/lip-taskrunner/main_test.go
  • tools/taskrunner/cmd/lip-taskrunner/profile.go
  • tools/taskrunner/cmd/lip-taskrunner/profile_test.go
  • tools/taskrunner/process.go
  • tools/taskrunner/process_other.go
  • tools/taskrunner/process_posix.go
  • tools/taskrunner/process_tree_posix_test.go
  • tools/taskrunner/process_tree_windows_test.go
  • tools/taskrunner/process_windows.go
  • tools/taskrunner/runner.go
  • tools/taskrunner/runner_contract_test.go
  • tools/taskrunner/testhelper/main.go

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matdev83
matdev83 merged commit 40474cb into main Aug 1, 2026
23 checks passed
@matdev83
matdev83 deleted the fix/windows-task-reliability branch August 1, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant