Skip to content

now it's URI.decode -> Addressable::URI.unescape #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbkidd merged 1 commit into from
Apr 26, 2026
Merged

now it's URI.decode -> Addressable::URI.unescape #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/links.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# encoding: UTF-8
require 'addressable/uri'
require 'uri'

class Links < Linkbot::Plugin
Expand Down Expand Up @@ -31,7 +32,7 @@ def on_message(message, matches)
# So, split on the pipe and take the first thing until we get around to
# chopping up that regex
url = matches[0].split('|')[0]
url = URI.decode(url)
url = Addressable::URI.unescape(url)
uri = URI.parse(url)

# First, make sure this is a HTTP or HTTPS scheme
Expand Down
2 changes: 1 addition & 1 deletion plugins/urban.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def on_message(message, match)
word = Addressable::URI.escape(match[0])
doc = JSON.parse(http_get("http://www.urbandictionary.com/iphone/search/define?term=#{word}"))
if doc["result_type"] == "exact"
"\"#{URI.decode(word)}\": " + doc["list"][0]["definition"] + "\n" + "Example usage: " + doc["list"][0]["example"]
"\"#{Addressable::URI.unescape(word)}\": " + doc["list"][0]["definition"] + "\n" + "Example usage: " + doc["list"][0]["example"]
else
"No match!"
end
Expand Down
Loading