Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the package version to 18.0.0-0 and updates the 'marked' and 'marked-repo' dependencies to version 18.0.0. Review feedback indicates that an 'engines' field should be added to package.json to reflect the new Node.js >= 20 requirement. Furthermore, the upgrade involves breaking changes regarding the removal of 'pedantic' and 'silent' options, which are still in use within the test suite and require updates.
| { | ||
| "name": "@markedjs/testutils", | ||
| "version": "17.0.5-0", | ||
| "version": "18.0.0-0", | ||
| "description": "Test utilities for marked and marked extensions", | ||
| "main": "lib/index.js", | ||
| "types": "lib/index.d.ts", |
There was a problem hiding this comment.
marked v18 requires Node.js >= 20. It is recommended to add an engines field to package.json to reflect this requirement and ensure compatibility with the updated dependency.
{
"name": "@markedjs/testutils",
"version": "18.0.0-0",
"description": "Test utilities for marked and marked extensions",
"engines": {
"node": ">= 20"
},
"main": "lib/index.js",
"types": "lib/index.d.ts",| "marked": "18.0.0", | ||
| "marked-repo": "https://github.com/markedjs/marked/tarball/v18.0.0" |
There was a problem hiding this comment.
The upgrade to marked v18 introduces breaking changes regarding removed options. The pedantic and silent options have been removed (in v12 and v11 respectively) and are now ignored. The codebase in src/run-tests.ts still uses these options; specifically, the "Original" spec tests (line 133) rely on pedantic: true to simulate legacy behavior, which will no longer work. These tests should be updated to use appropriate extensions or alternative configurations.
1 participant
No description provided.