Preconfigurable providers#646
Open
cxrtisxl wants to merge 3 commits into
Open
Conversation
…eturn type to goth.Provider, updated provider_test.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
ProviderConfiginterface that allows to separate Provider configuration from Provider creation.Why?
Primarly because Provider's
Newmethods require to setCallbackURLat creation time. At complex Routers this might be set programmatically but Provider hasCallbackURLunmutable after its creation.gothcontains all the Providers in separate package so my decision here was to create aProviderConfiginterface andConfigstruct for all the providers, that will containNewmethod's params and will produce the correspondingProviderviaProviderConfig.Build().The interface includes 3 methods:
Name() string- returns the default Config's Provider nameSetCallbackURL(string)- allows to set URL (all Providers have it)Build() Provider- runsNewmethod passing Config data as paramsHere's how it looks for the Google Provider:
What it allows to do - provide only configs at init time:
and build Providers later, let's say somewhere in oauth module:
I made a generalized test in
provider_test.go. Probably can cover more providers and cases it you find it an interesting feature to add to originalgothpackage.