Skip to content

chore: retains apiversion in app description and app deployments - #189

Open
vireshnavalli wants to merge 4 commits into
pre-draftfrom
chore/134-apiversion-changes
Open

chore: retains apiversion in app description and app deployments#189
vireshnavalli wants to merge 4 commits into
pre-draftfrom
chore/134-apiversion-changes

Conversation

@vireshnavalli

Copy link
Copy Markdown
Contributor

Description

As the API routes include version within URL there is not need to explicitly have 'apiVersion' attribute for margo specified REST apis . Keeping the apiVersion in ApplicationDescription and ApplicationDeployment, although the version string needs to be the same as the OpenAPI version and follow semantic versioning.

Issues Addressed

Address #134

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)
  • Content edits (change that edits existing content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

@vireshnavalli
vireshnavalli requested a review from a team as a code owner June 18, 2026 04:40
@vireshnavalli
vireshnavalli marked this pull request as draft June 18, 2026 04:40

@nilanjan-samajdar nilanjan-samajdar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apiVersion should be v1.0.0-rc.2
Corresponding to the recently release spec version v1.0.0-rc.2

Comment thread src/specification/margo-management-interface/resources/index.md.jinja2 Outdated
@phil-abb

Copy link
Copy Markdown
Contributor

Issue #134 is in the Gen. Improvements SUP Required column. There was no SUP for this creation.

@jachstet-sea

jachstet-sea commented Jun 18, 2026

Copy link
Copy Markdown
Member

Since apiVersion: margo.org/v1-alpha1 is what is contained in the tags https://github.com/margo/specification/releases/tag/v1.0.0-rc.2 and https://github.com/margo/specification/releases/tag/plugfest-2026-07 I assume that the change proposed here (which makes sense) will be done AFTER the July Plugfest and we will keep apiVersion: margo.org/v1-alpha1 for the plugfest?

@ajcraig

ajcraig commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Issue #134 is in the Gen. Improvements SUP Required column. There was no SUP for this creation.

Yes, @vireshnavalli please close this PR and recreate as a SUP within the specification enhancements repository.

Since apiVersion: margo.org/v1-alpha1 is what is contained in the tags https://github.com/margo/specification/releases/tag/v1.0.0-rc.2 and https://github.com/margo/specification/releases/tag/plugfest-2026-07 I assume that the change proposed here (which makes sense) will be done AFTER the July Plugfest and we will keep apiVersion: margo.org/v1-alpha1 for the plugfest?

@jachstet-sea: This PR will be closed so changs will not be implemented prior to plugfest. As for the API definition that will be the baseline for Plugfest testing, the current version is 1.0.0 although incorrect that's what we will run with during plugfest.

I'll let the newly created SUP work out the API versioning strategy.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 13, 2026

Copy link
Copy Markdown

CLA Signed

@vireshnavalli
vireshnavalli force-pushed the chore/134-apiversion-changes branch 2 times, most recently from 8006033 to 7ea453d Compare August 13, 2026 08:58
@vireshnavalli
vireshnavalli force-pushed the chore/134-apiversion-changes branch from 7ea453d to 94bd96c Compare August 13, 2026 09:05
…apiVersion and removde kind attribute in ApplicationDescription)

Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
@vireshnavalli vireshnavalli reopened this Aug 13, 2026
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
@vireshnavalli
vireshnavalli marked this pull request as ready for review August 18, 2026 11:08
@vireshnavalli

Copy link
Copy Markdown
Contributor Author

@margo/technical-wg / @margo/development-team changes for #189 is ready for review.

@phil-abb phil-abb linked an issue Aug 18, 2026 that may be closed by this pull request
Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/application-description.linkml.yaml Outdated
Comment thread src/specification/applications/application-description.linkml.yaml
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
Comment thread system-design/specification/specification-version-management.md Outdated
Signed-off-by: vireshnavalli <viresh-r.navalli@capgemini.com>
@vireshnavalli

Copy link
Copy Markdown
Contributor Author

Hi @matlec @ajcraig Could you please review this once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document expected apiVersion values for all API resources

5 participants