Repository navigation
Count lines from 1 in error and warning locations - #21
Merged
Merged
Conversation
marcoroth
force-pushed
the
one-based-line-numbers
branch
from
October 14, 2026 06:21
235cb8d to
0d6d056
Compare
marcoroth
enabled auto-merge (squash)
October 14, 2026 06:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the locations in error messages and warnings to count lines from 1, so they point at the line with the problem instead of the one above it.
This follows Prism and Herb, which both count lines from 1. Columns in the messages already count from 1, the same as the column Herb prints in its messages, so they stay as they are.
Resolves #17