fix: directions_tool turn-by-turn instructions never populated - #256
Open
mattpodwysocki wants to merge 1 commit into
Open
fix: directions_tool turn-by-turn instructions never populated#256mattpodwysocki wants to merge 1 commit into
mattpodwysocki wants to merge 1 commit into
Conversation
The tool has always requested steps=true and documented its response as including "turn-by-turn instructions", but the extraction read step.voiceInstructions, which the Directions API only returns when the separate voice_instructions=true parameter is set -- never sent by this tool. So `instructions` was silently empty for every call. Switched to step.maneuver.instruction, a human-readable instruction string already present on every step whenever steps=true is set, no extra parameter needed. Raised the output cap from 10 to 200: the old cap was sized for the old source (which could emit several announcements per turn), while maneuver.instruction is one entry per real turn, so a normal route -- even a long one with dozens of turns -- stays well under it. Confirmed live against the real Directions API. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directions_toolhas always requestedsteps=trueand documented its response as including "turn-by-turn instructions," but the extraction code read announcements fromstep.voiceInstructions— a field the Directions API only populates when the separatevoice_instructions=trueparameter is set, which this tool never sends. So theinstructionsfield was silently empty for every single call, short or long route alike.Fix: switch to
step.maneuver.instruction— a human-readable instruction string (e.g."Bear right onto Great Portland Street/A4201. Continue on A4201.") already present on every step wheneversteps=trueis set, no extra parameter needed.Also raised the output cap from 10 to 200. The old cap was calibrated for the old (broken) source, where a single turn could emit several verbose voice announcements.
maneuver.instructionis one entry per real turn, so a normal route — even a long one with dozens of turns — comfortably fits under the new cap; the old cap of 10 would have excluded instructions for almost any real multi-turn route once the underlying bug was fixed.Spun out of review discussion on #255.
Test plan
npx vitest run— all 939 tests pass, including updated/new coverage incleanResponseData.test.ts(real extraction shape, a step with no instruction, a realistic 40-turn route, and the new 200-instruction cap)npm run buildsucceeds, lint clean"Drive northeast on Market Street.","Turn right onto 10th Street.") where it previously returned noneCHANGELOG.mdupdated🤖 Generated with Claude Code