Fix StateEnum.toArray() to exercise recursion path and clean up test comments#7
Merged
maniaba merged 1 commit intobug-entityfrom Apr 26, 2026
Merged
Conversation
…eedback Agent-Logs-Url: https://github.com/maniaba/CodeIgniter4/sessions/81c8ece0-932b-44e0-9757-d80c5cb2fc6a Co-authored-by: maniaba <61078470+maniaba@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
maniaba
April 26, 2026 14:35
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
StateEnum::toArray()returned scalar strings, so the test never exercised the actual recursion path reported in the issue — wherenormalizeValue()callingtoArray()on an enum yields more enum objects (which also havetoArray()), risking infinite recursion.Changes
tests/_support/Enum/StateEnum.php: ChangedtoArray()to returnself::cases()(array ofUnitEnumobjects) instead of scalar strings viaarray_column. This ensures the test genuinely covers the recursive scenario.tests/system/Entity/EntityTest.php: Removed verbose inline comments fromtestInjectRawDataWithEnumThatHasToArrayMethod(); replaced with a@seedocblock pointing to the issue.