e2e: increase client route propagation timeout to reduce flakiness#3944
Merged
Conversation
The client-side route checks in TestE2E_MultiClientIBRLAllocatedIP waited only 60s, while the device-level iBGP checks that precede them in the propagation chain allow 90s. Since routes reach clients only after the devices learn them and re-advertise over the client BGP session, under CI load the client checks could time out even when propagation was healthy. Align the client timeouts with the 90s used for the device checks.
bgm-malbeclabs
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
TestE2E_MultiClientIBRLAllocatedIPfrom 60s to 90s, aligning them with the device-level iBGP checks that precede them in the propagation chainDiff Breakdown
Pure test-timing change; no production code affected.
Key files (click to expand)
e2e/multi_client_ibrl_allocated_ip_test.go— bump both client route-check timeouts from 60s to 90s to match the device-side iBGP propagation windowTesting Verification
TestE2E_MultiClientIBRLAllocatedIPlocally in a repeat loop to confirm it no longer flakes (first iteration passed in 666s; additional iterations in progress).