Skip to content

e2e: increase client route propagation timeout to reduce flakiness#3944

Merged
juan-malbeclabs merged 1 commit into
mainfrom
jo/fix-flaky-multiclient-ibrl-e2e
Jun 27, 2026
Merged

e2e: increase client route propagation timeout to reduce flakiness#3944
juan-malbeclabs merged 1 commit into
mainfrom
jo/fix-flaky-multiclient-ibrl-e2e

Conversation

@juan-malbeclabs

Copy link
Copy Markdown
Contributor

Summary of Changes

  • Increase the client-side route propagation timeouts in TestE2E_MultiClientIBRLAllocatedIP from 60s to 90s, aligning them with the device-level iBGP checks that precede them in the propagation chain
  • Fixes intermittent CI failures ("client1 should have route to client2", condition never satisfied) caused by the client checks expiring before routes finished propagating under load

Diff Breakdown

Category Files Lines (+/-) Net
Tests 1 +2 / -2 +0

Pure test-timing change; no production code affected.

Key files (click to expand)
  • e2e/multi_client_ibrl_allocated_ip_test.go — bump both client route-check timeouts from 60s to 90s to match the device-side iBGP propagation window

Testing Verification

  • Routes reach a client only after its device learns them via iBGP (90s budget) and re-advertises them over the client BGP session; the client checks previously allowed only 60s, so a near-limit device propagation left insufficient time for the client install. Raising the client budget to 90s removes that race.
  • Ran TestE2E_MultiClientIBRLAllocatedIP locally in a repeat loop to confirm it no longer flakes (first iteration passed in 666s; additional iterations in progress).

The client-side route checks in TestE2E_MultiClientIBRLAllocatedIP waited
only 60s, while the device-level iBGP checks that precede them in the
propagation chain allow 90s. Since routes reach clients only after the
devices learn them and re-advertise over the client BGP session, under CI
load the client checks could time out even when propagation was healthy.
Align the client timeouts with the 90s used for the device checks.
@juan-malbeclabs juan-malbeclabs merged commit f4efc33 into main Jun 27, 2026
34 of 35 checks passed
@juan-malbeclabs juan-malbeclabs deleted the jo/fix-flaky-multiclient-ibrl-e2e branch June 27, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants