feat(i18n): enhance Hindi (hi) locale and align with latest schema#8897
feat(i18n): enhance Hindi (hi) locale and align with latest schema#8897Rugvedrc wants to merge 2 commits intomakeplane:previewfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded Hindi ("hi") language support to the i18n package: new Hindi locale modules (translations, accessibility, empty-state, editor), registry entry for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/i18n/src/locales/hi/translations.ts`:
- Around line 272-283: The Hindi translations file is missing top-level keys
present in English (old_password, general_settings, sign_out, signing_out) after
the notification section around the notify_me_when/work_items area; add those
keys to packages/i18n/src/locales/hi/translations.ts with appropriate Hindi
translations (or temporary placeholders) using the same key names (old_password,
general_settings, sign_out, signing_out) so the schema matches the English file
and avoids lookup errors—insert them alongside the existing notify_me_when and
before work_items to mirror the original structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ce34cca8-a650-4dbe-b996-316a32db99d4
📒 Files selected for processing (7)
packages/i18n/src/constants/language.tspackages/i18n/src/locales/hi/accessibility.tspackages/i18n/src/locales/hi/editor.tspackages/i18n/src/locales/hi/empty-state.tspackages/i18n/src/locales/hi/translations.tspackages/i18n/src/locales/index.tspackages/i18n/src/types/language.ts
There was a problem hiding this comment.
Pull request overview
Adds Hindi (hi) as a supported i18n locale and provides Hindi translations/accessibility/empty-state strings, wired into the i18n loader and language selector.
Changes:
- Added
hito the supported language type union and language options list. - Registered
hilocale modules in the dynamiclocalesimport map. - Introduced initial Hindi locale files (
translations,accessibility,empty-state,editor).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/i18n/src/types/language.ts | Extends TLanguage union to include hi. |
| packages/i18n/src/constants/language.ts | Adds Hindi to SUPPORTED_LANGUAGES for UI selection/storage validation. |
| packages/i18n/src/locales/index.ts | Registers hi locale module imports for runtime loading/merging. |
| packages/i18n/src/locales/hi/translations.ts | Provides Hindi translation strings (schema-aligned keys for notifications, etc.). |
| packages/i18n/src/locales/hi/accessibility.ts | Adds Hindi ARIA labels (including “मोडल” wording). |
| packages/i18n/src/locales/hi/empty-state.ts | Adds Hindi empty-state copy for multiple product areas. |
| packages/i18n/src/locales/hi/editor.ts | Adds placeholder editor locale module (consistent with other locales). |
|
All requested schema-alignment fixes have been applied. Additional updates included:
Ready for maintainer review. Thanks! |
|
Hi maintainers 👋 This PR aligns the Hindi locale with the latest schema and resolves previous inconsistencies. All checks are passing and changes are scoped to i18n only. Would appreciate a review when you get a chance. Thanks! |
|
Hi maintainers 👋 This PR adds full Hindi (hi) locale support and aligns it with the latest i18n schema. The feature is tracked in #8900 and implementation is complete with:
Would appreciate a review or feedback when you get time. Happy to make any changes if needed. Thanks! |
Description
This PR enhances and refines the Hindi (hi) locale implementation by aligning it with the latest English i18n schema and improving overall consistency.
Key updates include:
property_changes,state_change,issue_completed,comments,mentions)मॉडल→मोडल)work_itemsType of Change
Screenshots and Media (if applicable)
N/A (Localization changes)
Test Scenarios
References
Related to previous Hindi locale additions and schema alignment improvements.
Summary by CodeRabbit