ci: gate sync on successful test workflow run#39
Merged
Conversation
Switch sync's trigger from `push: branches: [main]` to a workflow_run on the test workflow, with a job-level gate that only proceeds on `conclusion == success` (or manual dispatch). After a merge to main, sync now waits for pre-commit to finish and only patches the ArgoCD Applications if the test passed. The synced revision is the head_sha of the upstream workflow run (falling back to github.sha for manual dispatch). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After splitting test/sync into separate workflows, both were independently triggered on push to `main` — meaning sync could fire even if pre-commit failed on the merged commit. This switches `sync` to a `workflow_run` trigger that fires when the `test` workflow on `main` completes, gated on `conclusion == success`. Manual dispatch still works for re-syncing without a new commit.
The synced revision is taken from `github.event.workflow_run.head_sha` (with `github.sha` as a fallback for manual dispatch).
Test plan
🤖 Generated with Claude Code