Merged
Conversation
Sync ArgoCD was an entry on every PR's check list (showing as "skipping") because it lived in the same workflow as the pre-commit test job, gated by an if condition. Split into two workflows so the PR check list only contains the pre-commit run: - test.yml — pre-commit on PR + push to main - sync.yml — Sync ArgoCD on push to main only Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous `test-and-sync.yml` had both jobs in one workflow, with the sync job gated by `if: github.event_name == 'push' && github.ref == 'refs/heads/main'`. That made `Sync ArgoCD` appear as a `skipping` entry on every PR's check list — confusing because it looks like the workflow is doing something on PR.
Split into two workflows so the PR's check list is just `Pre-commit Tests`:
Test plan
🤖 Generated with Claude Code