fix(arc): narrow AutoscalingRunnerSet ignoreDifferences so SA syncs#32
Merged
fix(arc): narrow AutoscalingRunnerSet ignoreDifferences so SA syncs#32
Conversation
ignoring /spec/template wholesale also masks spec.template.spec changes like serviceAccountName, so the new arc-tf-runner SA never reached the runner pods and they kept booting under the chart's default arc-tf-gha-rs-no-permission SA. Restrict the ignore to the annotation paths the controller actually mutates so template spec changes sync. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous
ignoreDifferencesrule onAutoscalingRunnerSetignored the entire/spec/template, which masked legitimate changes likeserviceAccountName. Result: even afterarc-tf-runnerwas added in #31, runner pods kept spinning up under the chart's defaultarc-tf-gha-rs-no-permissionSA and the sync workflow failed withForbiddenonapplications.argoproj.io.This narrows the ignore to only
/spec/template/metadata/annotations— the path the gha-runner-scale-set controller actually mutates with hash propagation.Test plan
kubectl -n arc-runners get pods -o jsonpath='{..serviceAccountName}'showsarc-tf-runnermaintriggersSync ArgoCDjob and successfully patches the bootstrap Applications🤖 Generated with Claude Code